Skip to content

gh-122272: guarantee specifiers %F and %C for datetime.strftime to be 0-padded#122436

Merged
serhiy-storchaka merged 11 commits intopython:mainfrom
blhsing:fix-datetime-strftime-f-c-normalization
Aug 23, 2024
Merged

gh-122272: guarantee specifiers %F and %C for datetime.strftime to be 0-padded#122436
serhiy-storchaka merged 11 commits intopython:mainfrom
blhsing:fix-datetime-strftime-f-c-normalization

Conversation

@blhsing
Copy link
Contributor

@blhsing blhsing commented Jul 30, 2024

@blhsing blhsing marked this pull request as ready for review July 30, 2024 06:08
@blhsing blhsing requested review from abalkin and pganssle as code owners July 30, 2024 06:08
@serhiy-storchaka serhiy-storchaka self-requested a review July 30, 2024 10:54
@erlend-aasland
Copy link
Contributor

I won't be able to review this for at least a couple of weeks.

@blhsing
Copy link
Contributor Author

blhsing commented Aug 22, 2024

My last push produced an error in a thread sanitizer check from code completely unrelated to mine , so I thought I'd try "fixing" the error by rebasing my branch to the latest master in hope that someone else already fixed the issue, and that resulted in the massive inclusion of all commits between the master my branch was originally based on and the latest master.

I tried to undo my rebase by force-pushing my last commit to the branch, but it still results in the code owners of all unrelated commits being tagged as reviewers for this PR by GitHub. Sorry about that.

@methane
Copy link
Member

methane commented Aug 22, 2024

This is why merge is better than rebase when updating PR.

@blhsing
Copy link
Contributor Author

blhsing commented Aug 22, 2024

This is why merge is better than rebase when updating PR.

Lesson learned. Thanks.

@mhsmith
Copy link
Member

mhsmith commented Aug 22, 2024

I've restored the previous reviewers list.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington-app
Copy link

Thanks @blhsing for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @blhsing for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @blhsing and @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 126910edba812a01794f307b0cfa2a7f02bda190 3.12

@miss-islington-app
Copy link

Sorry, @blhsing and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 126910edba812a01794f307b0cfa2a7f02bda190 3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants